Skip to content

Conversation

thirstyice
Copy link
Contributor

Also fix my alphabetization error from last time I submitted

Also fix my alphabetization error from last time I submitted
Copy link
Contributor

github-actions bot commented Sep 7, 2024

Hi @thirstyice.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

Copy link
Contributor

github-actions bot commented Sep 7, 2024

A problem was found with your submission https://github.com/ThisSmartHouse/CoogleIOT

ERROR: Submission URL is already in the Library Manager index.

@github-actions github-actions bot added the topic: modification Change existing list entry label Sep 7, 2024
Copy link
Contributor

github-actions bot commented Sep 7, 2024

ERROR: Arduino Lint found errors with https://github.com/thirstyice/Olimex16x2:

Linting library in Olimex16x2
ERROR: Library name Olimex16x2 not found in the Library Manager index. Library names are not allowed to change after    
       being added to the index.                                                                                        
       See: https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name               
       (Rule LP018)                                                                                                     
WARNING: No license file found.                                                                                                                 
         See:                                                                                                                                   
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository
         (Rule LD002)                                                                                                                           
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 1 ERRORS, 2 WARNINGS

-------------------

Copy link
Contributor

github-actions bot commented Sep 7, 2024

Thanks for your interest in contributing to the Arduino Library Manager index @thirstyice
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot requested a review from per1234 September 7, 2024 22:44
@thirstyice
Copy link
Contributor Author

ERROR: Arduino Lint found errors with https://github.com/thirstyice/Olimex16x2:

Linting library in Olimex16x2
ERROR: Library name Olimex16x2 not found in the Library Manager index. Library names are not allowed to change after    
       being added to the index.                                                                                        
       See: https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name               
       (Rule LP018)                                                                                                     

Of course it's not found, this is me adding it?

WARNING: No license file found.
See:
https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository
(Rule LD002)

Fixed

WARNING: No example sketches found. Please provide examples.
See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
(Rule LD004)

Fixed

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thirstyice you are welcome to propose reordering of the URLs if you like, but please submit a separate pull request for each distinct operation type.

You are mashing two distinct operations into a single pull request here:

  • Submit https://github.com/thirstyice/Olimex16x2
  • Reorder https://github.com/ThisSmartHouse/CoogleIOT

This repository's automated pull request handling system isn't smart enough to be able to interpret pull requests that mash together multiple distinct operations, which is why you got that "Library name Olimex16x2 not found in the Library Manager index." error.

So please remove the reordering from this pull request so that it is purely a submission. The automated system will then be able to interpret it correctly.

@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Sep 7, 2024
@thirstyice
Copy link
Contributor Author

Will do

@thirstyice thirstyice closed this Sep 8, 2024
@thirstyice thirstyice deleted the patch-2 branch September 8, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: waiting for information More information must be provided before work can proceed topic: modification Change existing list entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants